SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 3.1.12
Threshold is
Effort is default
Files
org.itracker.services.authentication.AbstractPluggableAuthenticator
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
instanceof will always return true for all non-null values in org.itracker.services.authentication.AbstractPluggableAuthenticator.getConfigurationService(), since all org.itracker.services.ConfigurationService are instances of org.itracker.services.ConfigurationService | STYLE | BC_VACUOUS_INSTANCEOF | 85 | Medium |
instanceof will always return true for all non-null values in org.itracker.services.authentication.AbstractPluggableAuthenticator.getUserService(), since all org.itracker.services.UserService are instances of org.itracker.services.UserService | STYLE | BC_VACUOUS_INSTANCEOF | 69 | Medium |
org.itracker.services.authentication.adsson.ADIntegration
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
new org.itracker.services.authentication.adsson.ADIntegration() may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 36 | Medium |
org.itracker.services.implementations.ConfigurationServiceImpl
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to current in org.itracker.services.implementations.ConfigurationServiceImpl.initializeConfiguration() | STYLE | DLS_DEAD_LOCAL_STORE | 1135 | Medium |
Load of known null value in org.itracker.services.implementations.ConfigurationServiceImpl.setJndiPropertiesOverridePrefix(String) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 104 | Medium |
Redundant nullcheck of configuration, which is known to be non-null in org.itracker.services.implementations.ConfigurationServiceImpl.isConfigurationItemUpToDate(Configuration) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 371 | Medium |
Uninitialized read of jndiPropertiesOverridePrefix in new org.itracker.services.implementations.ConfigurationServiceImpl(Properties, ConfigurationDAO, CustomFieldDAO, CustomFieldValueDAO, LanguageDAO, ProjectScriptDAO, WorkflowScriptDAO) | CORRECTNESS | UR_UNINIT_READ | 80 | Medium |
Uninitialized read of mailSessionLookupName in new org.itracker.services.implementations.ConfigurationServiceImpl(Properties, ConfigurationDAO, CustomFieldDAO, CustomFieldValueDAO, LanguageDAO, ProjectScriptDAO, WorkflowScriptDAO) | CORRECTNESS | UR_UNINIT_READ | 83 | Medium |
org.itracker.services.implementations.ConfigurationServiceImpl.getLanguage(Locale) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 961 | Medium |
org.itracker.services.implementations.IssueServiceImpl
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Boxed value is unboxed and then immediately reboxed in org.itracker.services.implementations.IssueServiceImpl.getAllIssueAttachmentCount() | PERFORMANCE | BX_UNBOXING_IMMEDIATELY_REBOXED | 1351 | Medium |
org.itracker.services.implementations.NotificationServiceImpl
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.itracker.services.implementations.NotificationServiceImpl.handleNotification(Issue, Notification$Type, Map, String, Integer) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 318 | Medium |
org.itracker.services.implementations.ProjectServiceImpl
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to user in org.itracker.services.implementations.ProjectServiceImpl.updateProject(Project, Integer) | STYLE | DLS_DEAD_LOCAL_STORE | 377 | Medium |
org.itracker.services.implementations.UserServiceImpl
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant nullcheck of authenticator, which is known to be non-null in org.itracker.services.implementations.UserServiceImpl.allowPasswordUpdates(User, Object, int, int) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 900 | Medium |
Redundant nullcheck of authenticator, which is known to be non-null in org.itracker.services.implementations.UserServiceImpl.allowPermissionUpdates(User, Object, int, int) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 928 | Medium |
Redundant nullcheck of authenticator, which is known to be non-null in org.itracker.services.implementations.UserServiceImpl.allowPreferenceUpdates(User, Object, int, int) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 956 | Medium |
Redundant nullcheck of authenticator, which is known to be non-null in org.itracker.services.implementations.UserServiceImpl.allowProfileCreation(User, Object, int, int) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 844 | Medium |
Redundant nullcheck of authenticator, which is known to be non-null in org.itracker.services.implementations.UserServiceImpl.allowProfileUpdates(User, Object, int, int) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 872 | Medium |
Redundant nullcheck of authenticator, which is known to be non-null in org.itracker.services.implementations.UserServiceImpl.allowRegistration(User, Object, int, int) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 812 | Medium |
Redundant nullcheck of authenticator, which is known to be non-null in org.itracker.services.implementations.UserServiceImpl.checkLogin(String, Object, int, int) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 784 | Medium |
Redundant nullcheck of authenticator, which is known to be non-null in org.itracker.services.implementations.UserServiceImpl.updateAuthenticator(Integer, List) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 434 | Medium |
Redundant nullcheck of authenticator, which is known to be non-null in org.itracker.services.implementations.UserServiceImpl.updateUser(User) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 203 | Medium |