PMD Results

The following document contains the results of PMD 5.3.2.

Files

org/itracker/core/ApplicationInitialization.java

Violation Line
Avoid unused private fields such as 'servletConfig'. 50
Avoid unused constructor parameters such as 'reportService'. 52

org/itracker/core/resources/ITrackerResources.java

Violation Line
Useless parentheses. 470
Useless parentheses. 470
Useless parentheses. 470

org/itracker/model/AbstractEntity.java

Violation Line
Useless parentheses. 148

org/itracker/model/CustomField.java

Violation Line
Avoid unused private fields such as 'logger'. 70

org/itracker/model/CustomFieldValue.java

Violation Line
Useless parentheses. 76

org/itracker/model/ImportDataModel.java

Violation Line
Avoid unused private fields such as 'log'. 30

org/itracker/model/IntCodeEnum.java

Violation Line
Avoid modifiers which are implied by the context 29

org/itracker/model/IssueAttachment.java

Violation Line
Useless parentheses. 134

org/itracker/model/IssueField.java

Violation Line
Useless parentheses. 221

org/itracker/model/util/IssueUtilities.java

Violation Line
These nested if statements could be combined 130–132
These nested if statements could be combined 627–634
These nested if statements could be combined 703–709
Useless parentheses. 812

org/itracker/model/util/ProjectUtilities.java

Violation Line
Useless parentheses. 115

org/itracker/model/util/SystemConfigurationUtilities.java

Violation Line
Avoid empty catch blocks 99–101
Avoid empty catch blocks 101–103

org/itracker/model/util/UserUtilities.java

Violation Line
Useless parentheses. 244
Useless parentheses. 319
Useless parentheses. 414

org/itracker/model/util/WorkflowUtilities.java

Violation Line
Avoid unused private fields such as 'logger'. 60

org/itracker/persistence/dao/AbstractEnumUserType.java

Violation Line
Useless parentheses. 75

org/itracker/persistence/dao/BaseDAO.java

Violation Line
Avoid modifiers which are implied by the context 17
Avoid modifiers which are implied by the context 26
Avoid modifiers which are implied by the context 33
Avoid modifiers which are implied by the context 40
Avoid modifiers which are implied by the context 47
Avoid modifiers which are implied by the context 56

org/itracker/persistence/dao/ConfigurationDAO.java

Violation Line
Avoid modifiers which are implied by the context 12
Avoid modifiers which are implied by the context 14
Avoid modifiers which are implied by the context 22
Avoid modifiers which are implied by the context 25
Avoid modifiers which are implied by the context 33
Avoid modifiers which are implied by the context 41

org/itracker/persistence/dao/CustomFieldDAO.java

Violation Line
Avoid modifiers which are implied by the context 10
Avoid modifiers which are implied by the context 12

org/itracker/persistence/dao/CustomFieldValueDAO.java

Violation Line
Avoid modifiers which are implied by the context 12
Avoid modifiers which are implied by the context 14

org/itracker/persistence/dao/IntBooleanType.java

Violation Line
Useless parentheses. 50

org/itracker/persistence/dao/ProjectDAO.java

Violation Line
Avoid modifiers which are implied by the context 46

org/itracker/persistence/dao/TimestampInterceptor.java

Violation Line
Useless parentheses. 80

org/itracker/persistence/dao/UserPreferencesDAO.java

Violation Line
Avoid modifiers which are implied by the context 10

org/itracker/persistence/dao/VersionDAO.java

Violation Line
Avoid modifiers which are implied by the context 12
Avoid modifiers which are implied by the context 14

org/itracker/persistence/dao/WorkflowScriptDAO.java

Violation Line
Avoid modifiers which are implied by the context 19
Avoid modifiers which are implied by the context 26

org/itracker/services/ConfigurationService.java

Violation Line
Avoid modifiers which are implied by the context 34
Avoid modifiers which are implied by the context 457

org/itracker/services/IssueService.java

Violation Line
Avoid modifiers which are implied by the context 240

org/itracker/services/NotificationService.java

Violation Line
Avoid modifiers which are implied by the context 77

org/itracker/services/ProjectService.java

Violation Line
Avoid modifiers which are implied by the context 31
Avoid modifiers which are implied by the context 33
Avoid modifiers which are implied by the context 35
Avoid modifiers which are implied by the context 37
Avoid modifiers which are implied by the context 39
Avoid modifiers which are implied by the context 41
Avoid modifiers which are implied by the context 43
Avoid modifiers which are implied by the context 45
Avoid modifiers which are implied by the context 47
Avoid modifiers which are implied by the context 49
Avoid modifiers which are implied by the context 51
Avoid modifiers which are implied by the context 53
Avoid modifiers which are implied by the context 55
Avoid modifiers which are implied by the context 57
Avoid modifiers which are implied by the context 59
Avoid modifiers which are implied by the context 61
Avoid modifiers which are implied by the context 63
Avoid modifiers which are implied by the context 65
Avoid modifiers which are implied by the context 67
Avoid modifiers which are implied by the context 69
Avoid modifiers which are implied by the context 71
Avoid modifiers which are implied by the context 73
Avoid modifiers which are implied by the context 75
Avoid modifiers which are implied by the context 83
Avoid modifiers which are implied by the context 85
Avoid modifiers which are implied by the context 87
Avoid modifiers which are implied by the context 89
Avoid modifiers which are implied by the context 97
Avoid modifiers which are implied by the context 108
Avoid modifiers which are implied by the context 110

org/itracker/services/ReportService.java

Violation Line
Avoid modifiers which are implied by the context 28
Avoid modifiers which are implied by the context 30
Avoid modifiers which are implied by the context 32
Avoid modifiers which are implied by the context 34

org/itracker/services/UserService.java

Violation Line
Avoid modifiers which are implied by the context 33
Avoid modifiers which are implied by the context 35
Avoid modifiers which are implied by the context 37
Avoid modifiers which are implied by the context 39
Avoid modifiers which are implied by the context 41
Avoid modifiers which are implied by the context 43
Avoid modifiers which are implied by the context 45
Avoid modifiers which are implied by the context 51
Avoid modifiers which are implied by the context 55
Avoid modifiers which are implied by the context 57
Avoid modifiers which are implied by the context 59
Avoid modifiers which are implied by the context 63
Avoid modifiers which are implied by the context 65
Avoid modifiers which are implied by the context 86
Avoid modifiers which are implied by the context 97
Avoid modifiers which are implied by the context 110
Avoid modifiers which are implied by the context 125
Avoid modifiers which are implied by the context 140
Avoid modifiers which are implied by the context 155
Avoid modifiers which are implied by the context 163
Avoid modifiers which are implied by the context 185
Avoid modifiers which are implied by the context 197
Avoid modifiers which are implied by the context 210
Avoid modifiers which are implied by the context 223
Avoid modifiers which are implied by the context 235
Avoid modifiers which are implied by the context 247
Avoid modifiers which are implied by the context 260
Avoid modifiers which are implied by the context 272
Avoid modifiers which are implied by the context 284
Avoid modifiers which are implied by the context 299
Avoid modifiers which are implied by the context 312
Avoid modifiers which are implied by the context 324
Avoid modifiers which are implied by the context 337
Avoid modifiers which are implied by the context 350

org/itracker/services/authentication/TestAuthenticator.java

Violation Line
Useless parentheses. 24

org/itracker/services/authentication/adsson/ADIntegration.java

Violation Line
Useless parentheses. 68
Useless parentheses. 75
Useless parentheses. 82
Useless parentheses. 89
Useless parentheses. 96

org/itracker/services/authentication/adsson/GetUserModelFromADPrivilegedAction.java

Violation Line
Useless parentheses. 44
Useless parentheses. 69
Useless parentheses. 78
Useless parentheses. 88
Useless parentheses. 88
Useless parentheses. 90

org/itracker/services/authentication/adsson/WindowsSSONAuthenticator.java

Violation Line
Useless parentheses. 124
Useless parentheses. 188

org/itracker/services/implementations/ConfigurationServiceImpl.java

Violation Line
These nested if statements could be combined 128–130
Avoid empty catch blocks 684–685
These nested if statements could be combined 961–973
Avoid unused local variables such as 'current'. 1107

org/itracker/services/implementations/IssueServiceImpl.java

Violation Line
Useless parentheses. 957

org/itracker/services/implementations/NotificationServiceImpl.java

Violation Line
Useless parentheses. 208–209
Avoid unused local variables such as 'versions'. 251
Useless parentheses. 470–471
Avoid unused local variables such as 'versions'. 513
These nested if statements could be combined 920–924

org/itracker/services/implementations/ProjectServiceImpl.java

Violation Line
Avoid unused private methods such as 'getCustomFieldDAO()'. 329
Avoid unused private methods such as 'getProjectScriptDAO()'. 333
Avoid unused local variables such as 'user'. 377
These nested if statements could be combined 389–391

org/itracker/services/implementations/UserServiceImpl.java

Violation Line
Avoid unused constructor parameters such as 'projectDAO'. 98
Avoid unused constructor parameters such as 'reportDAO'. 99
Avoid empty catch blocks 154–156
Useless parentheses. 244
Avoid empty if statements 420–421
Avoid unused local variables such as 'i'. 730

org/itracker/services/util/AuthenticationConstants.java

Violation Line
Avoid modifiers which are implied by the context 30
Avoid modifiers which are implied by the context 34
Avoid modifiers which are implied by the context 39
Avoid modifiers which are implied by the context 44
Avoid modifiers which are implied by the context 49
Avoid modifiers which are implied by the context 54
Avoid modifiers which are implied by the context 59
Avoid modifiers which are implied by the context 63
Avoid modifiers which are implied by the context 67
Avoid modifiers which are implied by the context 71
Avoid modifiers which are implied by the context 77
Avoid modifiers which are implied by the context 81
Avoid modifiers which are implied by the context 85

org/itracker/web/actions/PortalHomeAction.java

Violation Line
Useless parentheses. 274

org/itracker/web/actions/admin/AdminHomeAction.java

Violation Line
Avoid unused local variables such as 'numberDefinedKeys'. 77

org/itracker/web/actions/admin/configuration/EditConfigurationAction.java

Violation Line
These nested if statements could be combined 182–238

org/itracker/web/actions/admin/configuration/EditCustomFieldValueAction.java

Violation Line
Avoid unused local variables such as 'currOptions'. 81

org/itracker/web/actions/admin/configuration/ImportDataProcessAction.java

Violation Line
Avoid unused method parameters such as 'importer'. 132
Avoid unused method parameters such as 'importer'. 178

org/itracker/web/actions/admin/configuration/ImportDataVerifyAction.java

Violation Line
Avoid unused method parameters such as 'ic'. 126
Avoid unused method parameters such as 'ic'. 240
Avoid unused method parameters such as 'ic'. 284
Avoid unused method parameters such as 'ic'. 322

org/itracker/web/actions/admin/language/EditLanguageAction.java

Violation Line
Avoid empty catch blocks 158–160

org/itracker/web/actions/admin/language/EditLanguageFormAction.java

Violation Line
These nested if statements could be combined 105–113

org/itracker/web/actions/admin/project/EditProjectScriptAction.java

Violation Line
Useless parentheses. 83

org/itracker/web/actions/admin/user/EditUserFormAction.java

Violation Line
Useless parentheses. 64

org/itracker/web/actions/admin/user/LockUserAction.java

Violation Line
Useless parentheses. 49

org/itracker/web/actions/admin/user/UnlockUserAction.java

Violation Line
Useless parentheses. 51

org/itracker/web/actions/admin/workflow/EditWorkflowScriptAction.java

Violation Line
Avoid unused local variables such as 'eof'. 72
Avoid empty while statements 73–74

org/itracker/web/actions/issuesearch/SearchIssuesFormAction.java

Violation Line
Useless parentheses. 88
Invoke equals() on the object you've already ensured is not null 128

org/itracker/web/actions/project/CreateIssueAction.java

Violation Line
Avoid unused local variables such as 'scripts'. 118
These nested if statements could be combined 184–192
Useless parentheses. 186–189
Avoid unused method parameters such as 'issue'. 343
Avoid unused method parameters such as 'issueForm'. 344

org/itracker/web/actions/project/CreateIssueFormAction.java

Violation Line
Useless parentheses. 62

org/itracker/web/actions/project/EditIssueFormAction.java

Violation Line
Useless parentheses. 68–69

org/itracker/web/actions/project/MoveIssueAction.java

Violation Line
Avoid unused method parameters such as 'mapping'. 116

org/itracker/web/actions/project/MoveIssueFormAction.java

Violation Line
Useless parentheses. 63
These nested if statements could be combined 143–148

org/itracker/web/actions/project/ViewIssueAction.java

Violation Line
Useless parentheses. 62
Useless parentheses. 145–147

org/itracker/web/actions/project/ViewIssueActivityAction.java

Violation Line
Useless parentheses. 76–80
Useless parentheses. 77–80
Useless parentheses. 79
Useless parentheses. 79

org/itracker/web/actions/project/WatchIssueAction.java

Violation Line
Useless parentheses. 56

org/itracker/web/actions/user/ForgotPasswordAction.java

Violation Line
Useless parentheses. 119

org/itracker/web/filters/ExecuteAlwaysFilter.java

Violation Line
These nested if statements could be combined 115–127
Useless parentheses. 262
Unnecessary use of fully qualified name 'java.util.Date' due to existing import 'java.util.*' 327

org/itracker/web/forms/IssueForm.java

Violation Line
Useless parentheses. 305
Useless parentheses. 306
Avoid unused method parameters such as 'user'. 370
Avoid unused method parameters such as 'issueService'. 371
Useless parentheses. 478–480
Useless parentheses. 481–484
These nested if statements could be combined 557–563
An empty statement (semicolon) not part of a loop 722

org/itracker/web/forms/LoginForm.java

Violation Line
Useless parentheses. 77

org/itracker/web/forms/ProjectForm.java

Violation Line
Avoid empty if statements 235–236

org/itracker/web/forms/ReportForm.java

Violation Line
Avoid unused private fields such as 'reportType'. 44

org/itracker/web/ptos/UserPTO.java

Violation Line
Useless parentheses. 22
Useless parentheses. 26

org/itracker/web/servlets/AttachmentDownloadController.java

Violation Line
Useless parentheses. 71
Avoid unnecessary return statements 117

org/itracker/web/servlets/GenericController.java

Violation Line
Avoid unused private fields such as 'logger'. 65
Useless parentheses. 80

org/itracker/web/servlets/ReportDownloadController.java

Violation Line
Useless parentheses. 66
Avoid unnecessary return statements 87

org/itracker/web/servlets/RssFeedController.java

Violation Line
Overriding method merely calls super 49–52
Avoid unused local variables such as 'f'. 94
Avoid unused method parameters such as 'p'. 217
Avoid unused local variables such as 'componentsSize'. 244
Avoid unused local variables such as 'severityLocalizedString'. 244
Avoid unused local variables such as 'statusLocalizedString'. 244
Avoid unused method parameters such as 'ih'. 338
Avoid unused method parameters such as 'i'. 352

org/itracker/web/taglib/AddErrorTag.java

Violation Line
Useless parentheses. 59
Avoid empty catch blocks 72–73

org/itracker/web/taglib/ClearErrorsTag.java

Violation Line
Useless parentheses. 47
Avoid empty catch blocks 59–60

org/itracker/web/taglib/FormatCustomFieldTag.java

Violation Line
Avoid unused private fields such as 'logger'. 48
Avoid empty catch blocks 206–208
Avoid empty catch blocks 208–210
Useless parentheses. 293

org/itracker/web/taglib/FormatDescriptionTag.java

Violation Line
Useless parentheses. 106

org/itracker/web/taglib/FormatHistoryEntryTag.java

Violation Line
Avoid empty catch blocks 163–164
Useless parentheses. 176

org/itracker/web/taglib/FormatImageActionTag.java

Violation Line
Useless parentheses. 257

org/itracker/web/taglib/FormatLinkTag.java

Violation Line
Useless parentheses. 211

org/itracker/web/taglib/FormatPaginationLinkTag.java

Violation Line
Useless parentheses. 104
Useless parentheses. 114
Useless parentheses. 126

org/itracker/web/taglib/FormatResolutionTag.java

Violation Line
Avoid empty catch blocks 94–95
Avoid empty catch blocks 100–102
Useless parentheses. 109

org/itracker/web/util/AttachmentUtilities.java

Violation Line
These nested if statements could be combined 45–48

org/itracker/web/util/EditCustomFieldActionUtil.java

Violation Line
Avoid unused private fields such as 'logger'. 7

org/itracker/web/util/EditIssueActionUtil.java

Violation Line
Useless parentheses. 26
Useless parentheses. 141

org/itracker/web/util/EditProjectFormActionUtil.java

Violation Line
Avoid unused private fields such as 'log'. 12

org/itracker/web/util/HTMLUtilities.java

Violation Line
Avoid unnecessary temporaries when converting primitives to Strings 150

org/itracker/web/util/ImportExportTags.java

Violation Line
Avoid modifiers which are implied by the context 31
Avoid modifiers which are implied by the context 32
Avoid modifiers which are implied by the context 33
Avoid modifiers which are implied by the context 35
Avoid modifiers which are implied by the context 36
Avoid modifiers which are implied by the context 37
Avoid modifiers which are implied by the context 38
Avoid modifiers which are implied by the context 39
Avoid modifiers which are implied by the context 40
Avoid modifiers which are implied by the context 41
Avoid modifiers which are implied by the context 46
Avoid modifiers which are implied by the context 47
Avoid modifiers which are implied by the context 49
Avoid modifiers which are implied by the context 50
Avoid modifiers which are implied by the context 51
Avoid modifiers which are implied by the context 52
Avoid modifiers which are implied by the context 53
Avoid modifiers which are implied by the context 54
Avoid modifiers which are implied by the context 55
Avoid modifiers which are implied by the context 56
Avoid modifiers which are implied by the context 57
Avoid modifiers which are implied by the context 58
Avoid modifiers which are implied by the context 59
Avoid modifiers which are implied by the context 60
Avoid modifiers which are implied by the context 61
Avoid modifiers which are implied by the context 62
Avoid modifiers which are implied by the context 63
Avoid modifiers which are implied by the context 64
Avoid modifiers which are implied by the context 65
Avoid modifiers which are implied by the context 66
Avoid modifiers which are implied by the context 67
Avoid modifiers which are implied by the context 68
Avoid modifiers which are implied by the context 69
Avoid modifiers which are implied by the context 70
Avoid modifiers which are implied by the context 71
Avoid modifiers which are implied by the context 72
Avoid modifiers which are implied by the context 73
Avoid modifiers which are implied by the context 74
Avoid modifiers which are implied by the context 75
Avoid modifiers which are implied by the context 76
Avoid modifiers which are implied by the context 77
Avoid modifiers which are implied by the context 78
Avoid modifiers which are implied by the context 79
Avoid modifiers which are implied by the context 80
Avoid modifiers which are implied by the context 81
Avoid modifiers which are implied by the context 82
Avoid modifiers which are implied by the context 83
Avoid modifiers which are implied by the context 84
Avoid modifiers which are implied by the context 85
Avoid modifiers which are implied by the context 86
Avoid modifiers which are implied by the context 87
Avoid modifiers which are implied by the context 88
Avoid modifiers which are implied by the context 89
Avoid modifiers which are implied by the context 90
Avoid modifiers which are implied by the context 91
Avoid modifiers which are implied by the context 92
Avoid modifiers which are implied by the context 93
Avoid modifiers which are implied by the context 94
Avoid modifiers which are implied by the context 95
Avoid modifiers which are implied by the context 96
Avoid modifiers which are implied by the context 97
Avoid modifiers which are implied by the context 98
Avoid modifiers which are implied by the context 99
Avoid modifiers which are implied by the context 100
Avoid modifiers which are implied by the context 101
Avoid modifiers which are implied by the context 102
Avoid modifiers which are implied by the context 103
Avoid modifiers which are implied by the context 104
Avoid modifiers which are implied by the context 105
Avoid modifiers which are implied by the context 106
Avoid modifiers which are implied by the context 107
Avoid modifiers which are implied by the context 108
Avoid modifiers which are implied by the context 109
Avoid modifiers which are implied by the context 110
Avoid modifiers which are implied by the context 111
Avoid modifiers which are implied by the context 112
Avoid modifiers which are implied by the context 113
Avoid modifiers which are implied by the context 114
Avoid modifiers which are implied by the context 115
Avoid modifiers which are implied by the context 116
Avoid modifiers which are implied by the context 117
Avoid modifiers which are implied by the context 118
Avoid modifiers which are implied by the context 119

org/itracker/web/util/ImportHandler.java

Violation Line
Avoid empty if statements 263–266
Avoid empty catch blocks 376–378

org/itracker/web/util/ListIssuesActionUtil.java

Violation Line
Avoid empty catch blocks 132–133
These nested if statements could be combined 140–142
These nested if statements could be combined 186–188
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 208

org/itracker/web/util/LoginUtilities.java

Violation Line
These nested if statements could be combined 52–63
Useless parentheses. 401–402
R.Ø.S.A.